Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update git-clone 0.4 task for 1.5.0 #342

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Update git-clone 0.4 task for 1.5.0 #342

merged 1 commit into from
Jul 1, 2021

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jul 1, 2021 •
edited
Loading

Changes

Backporting tektoncd/catalog#763, mainly for git-clone task

/cc @nikhil-thomas @pradeepitm12

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@vdemeester
Update git-clone 0.4 task for 1.5.0
e01659d 
Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2021
@nikhil-thomas
Copy link
Member

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2021
pradeepitm12
pradeepitm12 approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas, pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member Author

/retest

@vdemeester
Copy link
Member Author

/retest
For some reason jobs get killed...

@vdemeester
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit f12839d into tektoncd:main Jul 1, 2021
@vdemeester vdemeester deleted the fix-git-clone-from-upstream branch July 1, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradeepitm12 pradeepitm12 pradeepitm12 approved these changes

@nikhil-thomas nikhil-thomas Awaiting requested review from nikhil-thomas

Assignees

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vdemeester @nikhil-thomas @tekton-robot @pradeepitm12